Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting more build environments #748

Merged
merged 28 commits into from
Mar 28, 2021
Merged

Supporting more build environments #748

merged 28 commits into from
Mar 28, 2021

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Mar 28, 2021

  • adds an alternative eager implementation for importSync that works in all ES module environments (at the cost of making some synchronous-but-lazy things become eager)
  • refactored core so that parts of it are easier to consume from browser code without pulling in node-specific features
  • updated app-js and fastboot-js metadata to a stricter form that requires all files by listed explicitly, not just the directories.
  • made it easier for compat adapters to edit the output package.json, beyond just the ember-addon section.
  • updated several places to keep explicit file extensions within the build, where in the past we were unnecessarily stripping them off

@ef4
[experimental] an eager mode for importSync
66b93cd 
This has the benefit of not requiring anything beyond web standards, and the downside of making some things eager that used to be lazy.
@ef4
Merge remote-tracking branch 'origin/master' into importSync-eager-mode
ad28a2f
@ef4
[wip]
be25c44
@ef4
[wip]
29453de
@ef4
Merge remote-tracking branch 'origin/master' into the-platform
0b3a259
@ef4
refactoring template compiler to separate out node-isms
37494e2
@ef4
more template-compiler refactorings
36c73e2
@ef4
split template compiler into node and common
84b4b98
@ef4
improved template loading
2c0883f
@ef4
Merge remote-tracking branch 'origin/master' into the-platform
bcc3cec
@ef4
not needed in eager mode
05ab33c 
and it breaks right now anyway due to ownedByEmberPackage
@ef4
make app-js and fastboot-js explicitly list their files
56db384
@ef4
make whole packagejson more extensible
ee622da 
and use it in ember-source compat adapter to make sure we keep the template compiler
@ef4
fixup
547fb75
@ef4
cleaning up imports
71e45cc
@ef4
splitting out browser-safe parts of inilne-hbs plugin
f15cdf2
@ef4
more file extensions
d889a36
@ef4
Merge branch 'master' into the-platform
1619275
@ef4
finishing merge
ca63cef
@ef4
keep babel out of the core template compiler
a7fc231
@ef4
don't force eager mode always
fb101aa
@ef4
post-merge formatting
03cc3c6
@ef4
updating some tests to account for more explicit file extensions
b3bdd70
@ef4
use Package's packageJSON
5b9c466 
Because it's extended to account for non-resolvable deps.
@ef4
better error for broken app-js entries
ad49d5d
@ef4
update compat adapter to also update new app-js
d72faaf
@ef4
updating tests and making implicitModulesStrategy configurable
e6b5861
@ef4
updating tests to match new plugin module name
22910a3
@ef4 ef4 marked this pull request as ready for review March 28, 2021 13:49
@ef4 ef4 merged commit 031ce6d into master Mar 28, 2021
@ef4 ef4 deleted the the-platform branch March 28, 2021 13:50
@ef4 ef4 added the enhancement New feature or request label Mar 30, 2021
@rwjblue rwjblue mentioned this pull request Mar 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ef4